[Editor] Add a tooltip showing the alt text when hovering the alt-text button (bug 1844952) #16983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
approved these changes
Sep 20, 2023
Snuffleupagus
requested changes
Sep 20, 2023
There was a problem hiding this comment.
One thing that I find a little bit confusing is that the tooltip doesn't seem to visually differentiate between the description/decorative modes. (Perhaps a minor issue, but nonetheless something that I noticed.)
In practice this means that if you add "Marked as decorative" as the altText then it's not really possible to know from the tooltip alone which mode is active. Looking briefly at the specification it's not immediately clear to me if it addresses this, however my (possibly dumb) idea would be to use italic-text in the tooltip for the decorative mode?
calixteman
force-pushed
the
alt_text_tooltip
branch
from
cd2e8f4
to
7b988fe
Compare
…t button (bug 1844952)
calixteman
force-pushed
the
alt_text_tooltip
branch
from
7b988fe
to
7952a36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been added by UX to the specifications.
The goal is to help to visualize what the alt text is.